Skip to content

Validate HIP_TARGETS format and allow negative values #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

Validate HIP_TARGETS format and allow negative values #2481

merged 4 commits into from
Jun 16, 2025

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Jun 16, 2025 •
edited by antonwolfy
Loading

This PR suggests validating the format of HIP_TARGETS (set via --target-hip) to ensure it starts with gfx (e.g., gfx1030).
It also allows users to explicitly indicate that no AMD target should be used by passing values like --target-hip=OFF or --target-hip=FALSE matching the default behavior

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

antonwolfy
antonwolfy reviewed Jun 16, 2025
View reviewed changes
antonwolfy
antonwolfy reviewed Jun 16, 2025
View reviewed changes
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jun 16, 2025
@vlad-perevezentsev vlad-perevezentsev force-pushed the update_amd_target_handling branch from 2303820 to 3609217 Compare June 16, 2025 13:50
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_16 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.705%. remained the same
when pulling 3609217 on update_amd_target_handling
into 32e1b4e on master.

@vlad-perevezentsev vlad-perevezentsev merged commit b10bd15 into master Jun 16, 2025
61 of 71 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the update_amd_target_handling branch June 16, 2025 16:18
github-actions bot added a commit that referenced this pull request Jun 16, 2025
@github-actions
Validate HIP_TARGETS format and allow negative values (#2481)
a5fa551 
This PR suggests validating the format of `HIP_TARGETS` (set via
`--target-hip`) to ensure it starts with `gfx` (e.g., `gfx1030`).
It also allows users to explicitly indicate that no AMD target should be
used by passing values like `--target-hip=OFF` or `--target-hip=FALSE`
matching the default behavior b10bd15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vtavana vtavana Awaiting requested review from vtavana

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.19.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @coveralls @antonwolfy